default behavior for escaping quotes

[mgood]

Markup.escape escapes " to " by default, though this behavior is only necessary for attribute values. The methods for joining and interpolating with Markup objects were all using the default behavior until I switched Markup.join in r35 since it was breaking JavaScript? code which used quotes. I've left the other methods, but it seems like they should be consistent:

>>> print Element('br') + '"hello"'
<br/>"hello"
>>> print Markup('<br/>') + '"hello"'
<br/>&#34;hello&#34;

I guess this was safer in Trac where Markup may have been used like:

Markup('<a href="%s">%s</a>', href.wiki(), 'Wiki')

Thoughts?

[cmlenz]

I think a Markup instance should not make assumptions about whether it's going to be used inside or outside of an attribute value. For that reason it needs to use the “safest” kind of quoting, which incudes escaping quotes.

Can you explain in more detail what kind of scenario was causing the problem for you? I.e. why are you using Markup to construct a <script> element?

[cmlenz]

Okay, it looks like the actual issue here is that the WhitespaceFilter uses Markup.join() to join together separate text nodes. At this stage it actually is clear that the content isn't going to end up in an attribute value, so we can just add a parameter to disable the quote-escaping on the join() method.

[cmlenz]

Should be fixed in [58].