Edgewall Software

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#537 closed defect (fixed)

genshi on python 3.3 broken

Reported by: rp Owned by: hodgestar
Priority: critical Milestone: 0.7
Component: Parsing Version: 0.6
Keywords: Cc:



Genshi doesn't work with python 3.3 anymore. There is a change in the Python 3.3 ast tree syntax, they remove TryExcept? and TryFinally?, but added a combined Try node.

I attached a little patch adding a visit_Try method and hope it's kinda correct, atleast it somewhat works here.

Because I'm curious why is genshi not using the NodeVisitor? class?

Attachments (1)

py3.3_astfix.diff (1.5 KB) - added by rp 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by rp

comment:1 Changed 5 years ago by hodgestar

  • Owner changed from cmlenz to hodgestar
  • Status changed from new to assigned

comment:2 Changed 5 years ago by hodgestar

  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks for the patch. I committed it in r1192. I also fixed a change in the structure of the With node (it now has .items instead of a single item directly on the node itself).

I suspect the initially implementation in Genshi predates NodeVisitor and NodeTransformer.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain hodgestar.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.