messages within expressions in py:with directive don't get extracted

[cboos]

Just noticed that now with ​[T9454] and ​[T9455], but it's actually been a while...

Things like:

          <xi:include href="list_of_attachments.html"
                      py:with="alist = attachments; add_button_title = _('Attach another file')"/>

in ​source:trunk/trac/templates/attachment.html@9400#L86 are there since ages, and no Attach another file in the messages.pot.

[cboos]

Ah sorry, my reference to ​[T9454] was a bit confusing...

Take two: while trying to figure out why the two new messages introduced in that revision were not extracted, I realized that the message they replaced was also not extracted before. I then remembered that a gettext _(...) expression within a i18n:msg directive wouldn't be extracted (not sure if there's a ticket for that already, btw). Looking for a workaround, I tried to place those messages in a <py:with> directive, like that:

trac/wiki/templates/wiki_view.html

@@ -44 +44 @@
 
       <div class="wikipage searchable" py:choose="" xml:space="preserve">
         <py:when test="page.exists">
-          <div py:if="not version" class="trac-modifiedby" i18n:msg="reldate">
-            <a href="${href.wiki(page.name, action='diff', version=page.version)}"
-               title="${page.comment and _('Version %(version)s by %(author)s: %(comment)s',
-                                           version=page.version, author=format_author(page.author), comment=page.comment)
-                                     or _('Version %(version)s by %(author)s',
-                                          version=page.version, author=format_author(page.author))}">
-              Last modified</a> ${dateinfo(page.time)} ago
-          </div>
+          <py:with vars="last_mod_comment = _('Version %(version)s by %(author)s: %(comment)s',
+                                              version=page.version, author=format_author(page.author),
+                                              comment=page.comment);
+                         last_mod = _('Version %(version)s by %(author)s',
+                                      version=page.version, author=format_author(page.author))">
+            <div py:if="not version" class="trac-modifiedby" i18n:msg="reldate">
+              <a href="${href.wiki(page.name, action='diff', version=page.version)}"
+                 title="${page.comment and last_mod_comment or last_mod}">Last modified</a>
+                 ${dateinfo(page.time)} ago
+            </div>
+          </py:with>
           <div id="wikipage" py:content="wiki_to_html(context, text)" />
         </py:when>
         <py:otherwise>

Alas, no luck for this one as well, hence this ticket.

Would be nice to fix either of those two extraction issues, or suggest another workaround...

[cboos]

Just found a workaround: using a <?python ?> PI instead of the <py:with>, see ​[T9456].

Still...

[cmlenz]

Replying to cboos:

Take two: while trying to figure out why the two new messages introduced in that revision were not extracted, I realized that the message they replaced was also not extracted before. I then remembered that a gettext _(...) expression within a i18n:msg directive wouldn't be extracted (not sure if there's a ticket for that already, btw). Looking for a workaround, I tried to place those messages in a <py:with> directive, like that:

So part of the underlying problem was that attribute values in markup embedded in i18n:msg and i18n:choose directives would not get extracted. This should be fixed in [1115].

I still need to add unit tests for the case where you have actual gettext() function calls in attribute values, but I think that should also work now.

[cboos]

Remaining problems in Trac concerning this topic, if I do the following changes to get rid of the <?python ... ?> trick:

trac/templates/attachment.html

@@ -82 +82 @@
 
       <py:when test="'list'">
         <h1><a href="${url_of(parent)}">${name_of(parent)}</a></h1>
-        <py:with vars="context = context(parent)">
-          <?python add_button_title = _('Attach another file') ?>
+        <py:with vars="context = context(parent);
+                       add_button_title = _('Attach another file')">
           <xi:include href="list_of_attachments.html" py:with="alist = attachments"/>
         </py:with>
       </py:when>

trac/wiki/templates/wiki_view.html

@@ -42 +42 @@
         </table>
       </py:if>
 
-      <div class="wikipage searchable" py:choose="" xml:space="preserve">
-        <py:when test="page.exists">
-          <?python
+      <div class="wikipage searchable" py:choose="" xml:space="preserve"
+          py:with="
             last_modification = (page.comment and
                  _('Version %(version)s by %(author)s: %(comment)s',
                    version=page.version, author=format_author(page.author), comment=page.comment) or
                  _('Version %(version)s by %(author)s',
-                   version=page.version, author=format_author(page.author)))
-          ?>
+                   version=page.version, author=format_author(page.author)))"
+        >
+        <py:when test="page.exists">
           <div py:if="not version" class="trac-modifiedby" i18n:msg="reldate">
             <a href="${href.wiki(page.name, action='diff', version=page.version)}"
                title="$last_modification">Last modified</a> ${dateinfo(page.time)} ago

I then lose the messages after doing an extraction (Genshi 0.6, Babel 0.9.5):

trac/locale/messages.pot

@@ -8 +8 @@
 msgstr ""
 "Project-Id-Version: Trac 0.12\n"
 "Report-Msgid-Bugs-To: trac-dev@googlegroups.com\n"
-"POT-Creation-Date: 2010-04-23 11:25+0200\n"
+"POT-Creation-Date: 2010-04-23 11:35+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -1585 +1585 @@
 msgid "Delete attachment"
 msgstr ""
 
-#: trac/templates/attachment.html:86
-msgid "Attach another file"
-msgstr ""
-
 #: trac/templates/attachment.html:98 trac/templates/list_of_attachments.html:22
 #: trac/templates/macros.html:19 trac/versioncontrol/templates/browser.html:110
 #: trac/versioncontrol/templates/dir_entries.html:16
@@ -5343 +5339 @@
 "               ([1:diff])"
 msgstr ""
 
-#: trac/wiki/templates/wiki_view.html:47
-#, python-format
-msgid "Version %(version)s by %(author)s: %(comment)s"
-msgstr ""
-
-#: trac/wiki/templates/wiki_view.html:47
-#, python-format
-msgid "Version %(version)s by %(author)s"
-msgstr ""
-
 #: trac/wiki/templates/wiki_view.html:54
 #, python-format
 msgid "[1:Last modified] %(reldate)s ago"

[Carsten Klein <carsten.klein@…>]

I am a bit confused. So you are setting the variable add_button_title. But where are you actually using this variable?

[Carsten Klein <carsten.klein@…>]

Replying to Carsten Klein <carsten.klein@…>:

I am a bit confused. So you are setting the variable add_button_title. But where are you actually using this variable?

-> forget this, stupid me. Must have been late.

[hodgestar]

Move to milestone 0.9.