i18n:msg wrongly extracted twice, as a whole and by pieces

[cboos]

Feel free to adjust the summary...

What happens is that a given element with i18n:msg attribute gets extracted twice in the resulting catalog template.

See ​changeset:8106#file2 for the .html source and ​changeset:8106#file1 for the .pot file.

This is seen with the advanced-i18n branch 0.6dev-r1028 and older revisions up to the beginning of the branch.

It should be noted that Genshi trunk successfully extracts only the whole content. Here's a diff based on ​trac:source:trunk/trac/locale/messages.pot@8106 after running a python setup.py extract_messages using Genshi trunk (r1052):

trac/locale/messages.pot

@@ -2723 +2723 @@
 msgstr ""
 
 #: trac/ticket/templates/ticket.html:128
-msgid "Opened"
-msgstr ""
-
-#: trac/ticket/templates/ticket.html:128 trac/ticket/templates/ticket.html:129
-msgid "ago"
-msgstr ""
-
-#: trac/ticket/templates/ticket.html:128
 #, python-format
 msgid "Opened %(created)s ago"
 msgstr ""
 
 #: trac/ticket/templates/ticket.html:129
-msgid "Last modified"
-msgstr ""
-
-#: trac/ticket/templates/ticket.html:129
 #, python-format
 msgid "Last modified %(modified)s ago"
 msgstr ""

[cboos]

​[T8108] exhibits the same issue with double extraction (I've filled the unwanted translations with "IGNORE: partial extraction - see below").

I've also noticed another issue with this translation which I'm not sure is related (it looks rather like #278, which I'll reopen in a minute).

[cboos]

Well, for some reason I assumed that regardless of the double extraction, the correct whole string was used at rendering time.

Apparently, the one which gets picked depends on the order within the compiled catalog, as I now see the following in my error page:

IGNORE: partial extraction - see below IGNORE: partial extraction - see below IGNORE: partial extraction - see belowIGNORE: partial extraction - see below IGNORE: partial extraction - see below IGNORE: partial extraction - see below

Not good...

[cboos]

Replying to cboos:

... Apparently, the one which gets picked depends on the order within the compiled catalog, as I now see the following in my error page:

Well, I can't reproduce that for now and at the time I had the above error page, I did mix up with a .mo compiled using Genshi trunk. So I don't know if we can end up with the wrong partial translation at runtime or if the "latest wins".

[palgarvio]

Fixed in [1056]. Please reopen if necessary.

[cboos]

Fix confirmed, it works both for the extraction and the rendering of the "Before you do that..." message and several other partial ones, thanks!

trac/locale/messages.pot

@@ -8 +8 @@
 msgstr ""
 "Project-Id-Version: Trac 0.12\n"
 "Report-Msgid-Bugs-To: trac-dev@googlegroups.com\n"
-"POT-Creation-Date: 2009-05-12 08:57+0200\n"
+"POT-Creation-Date: 2009-05-12 08:58+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -1560 +1560 @@
 msgstr ""
 
 #: trac/templates/error.html:131
-msgid "Before you do that, though, please first try"
-msgstr ""
-
-#: trac/templates/error.html:132
-msgid "searching"
-msgstr ""
-
-#: trac/templates/error.html:132
-msgid "for similar issues"
-msgstr ""
-
-#: trac/templates/error.html:133
-msgid ""
-", as it is quite likely that this problem\n"
-"                has been reported before. For questions about "
-"installation\n"
-"                and configuration of Trac, please try the"
-msgstr ""
-
-#: trac/templates/error.html:136
-msgid "mailing list"
-msgstr ""
-
-#: trac/templates/error.html:136
-msgid "instead of filing a ticket."
-msgstr ""
-
-#: trac/templates/error.html:131
 msgid ""
 "Before you do that, though, please first try\n"
 "                [1:[2:searching]\n"
@@ -2690 +2662 @@
 msgstr ""
 
 #: trac/ticket/templates/ticket.html:131
-msgid "Opened"
-msgstr ""
-
-#: trac/ticket/templates/ticket.html:131 trac/ticket/templates/ticket.html:132
-msgid "ago"
-msgstr ""
-
-#: trac/ticket/templates/ticket.html:131
 #, python-format
 msgid "Opened %(created)s ago"
 msgstr ""
 
 #: trac/ticket/templates/ticket.html:132
-msgid "Last modified"
-msgstr ""
-
-#: trac/ticket/templates/ticket.html:132
 #, python-format
 msgid "Last modified %(modified)s ago"
 msgstr ""