Edgewall Software

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#101 closed enhancement (fixed)

Add support for XInclude `parse` attribute

Reported by: djc@… Owned by: cmlenz
Priority: minor Milestone: 0.5
Component: Template processing Version: 0.4.3
Keywords: Cc:

Description

The parse attribute of the XInclude `include` element is a means of specifying whether the included document should be parsed as XML or as text.

At present (version 0.3.6) Genshi ignores the parse attribute and always tries to parse XIncluded documents as XML templates. This patch (to be attached) makes Genshi take note of the value of parse and parse the XIncluded document as an XML template or a text template as appropriate.

Attachments (2)

genshi-xinclude-parse-attr.patch (1.9 KB) - added by djc@… 17 years ago.
Patch to add support for XInclude parse attribute
genshi-0.4.3-xinclude-parse-attr.patch (3.2 KB) - added by djc@… 17 years ago.
Updated patch for genshi-0.4.3

Download all attachments as: .zip

Change History (7)

Changed 17 years ago by djc@…

Patch to add support for XInclude parse attribute

comment:1 Changed 17 years ago by cmlenz

  • Component changed from General to Template processing
  • Milestone set to 0.4
  • Status changed from new to assigned

Good idea, thanks!

comment:2 Changed 17 years ago by cmlenz

  • Milestone changed from 0.4 to 0.5

Not going to make it for 0.4. The move of the XInclude processing into the MarkupTemplate class has made this a bit harder to implement, unfortunately.

Changed 17 years ago by djc@…

Updated patch for genshi-0.4.3

comment:3 Changed 17 years ago by djc@…

  • Version changed from 0.3.6 to 0.4.3

I've attached a new patch that applies against 0.4.3. It works for me, but I'm not familiar enough with genshi internals to know whether it breaks anything elsewhere.

comment:4 Changed 17 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from assigned to closed

Implemented in [726], but only supports the new text template syntax introduced in trunk.

comment:5 Changed 17 years ago by cmlenz

Oh, and thanks for the patches!

Note: See TracTickets for help on using tickets.