#565 closed defect (fixed)
[PATCH] assert statement with sideeffect
| Reported by: | peinthor@… | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | major | Milestone: | 0.7 |
| Component: | Template processing | Version: | 0.6 |
| Keywords: | Cc: |
Description
Hi!
There is a nasty assert statement in markup.py with a sideeffect. And if for example you have an optimized genshi installation it breaks, because the assert call gets removed.
Patch is attached that should fix this.
Attachments (1)
Change History (6)
Changed 11 years ago by anonymous
comment:1 Changed 11 years ago by rblank
Wow, good catch. I wonder if this could be the cause of template include failures in Trac that some users have been experiencing, like #7463.
comment:2 Changed 11 years ago by peinthor@…
yes this breaks the xi:fallback it will just render until the first fallback statement and then completely stop.
comment:3 Changed 11 years ago by hodgestar
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed 11 years ago by warner
This bug just bit me (in trac), in Genshi-0.6.1 (the latest genshi that's selected by the latest stable trac-0.12.5, which says "Genshi<=0.6,<0.7dev"). I don't think the fix is in Genshi-0.7.0 either.
Has there been a 0.6.x or 0.7.x release that includes this fix?
-Brian Warner, tahoe-lafs.org
comment:5 Changed 10 years ago by hodgestar
Not yet, but there should be one soon.
patch for assert fix