loading a template twice fails when using prefix

[Waldemar Kornewald <wkornewald@…>]

The filepath is not formed correctly when using prefixes because the filename is simply appended to the dirname, resulting in paths like '.../app/templates/app/bla.html' instead of '.../app/templates/bla.html'. A possible solution would be to use a full filepath instead of a dirname which will get os.path.join()ed with the filename in the template class, anyway.

[Waldemar Kornewald <wkornewald@…>]

quick fix that adds support for filepath

[Waldemar Kornewald <wkornewald@…>]

Is it possible to simply replace the basedir parameter with the filepath? Looks like it's used in several places.

[Waldemar Kornewald <wkornewald@…>]

Ouch, my code isn't backwards-compatible because I always pass the filepath to the template class. :(

[Waldemar Kornewald <wkornewald@…>]

alternatively, replaced basedir with filepath

[Waldemar Kornewald <wkornewald@…>]

Well, since the previous patch wasn't backwards-compatible here is a patch that fully breaks basedir support and replaces that feature with a full filepath as it should be.

[cmlenz]

I cannot reproduce this and would really really like to see a test case before applying such a sweeping change as this.

[cmlenz]

Okay, I think I can reproduce some error in this respect, but a test case would still have been nice.

[cmlenz]

A much better description from IRC:

you can reproduce the bug by loading the same template twice. the cache code will try to access mtime for tmpl.filepath, but filepath points to an non-existent path

[Waldemar Kornewald <wkornewald@…>]

Sorry for the bad description in this ticket. Any ideas how to fix it without breaking backwards compatibility? I can only come up with hacky workarounds (like the loader setting tmpl.filepath manually after creating a new template instance). :(

[cmlenz]

Applied in [830]. Thanks!