Allow "Markup" constructor to be used from templates

[talin@…]

I have a couple of classes that generate XML (specifically, they take the output of 'diff' and convert them into <ins> and <del> tags). I'd like to be able to flag the result as XML so that Genshi doesn't attempt to escape the XML markup - however, I can't figure out how to call "Markup()" from within a template expression. Because the 'diff' classes know nothing about Genshi, I dont want to modify them to add the "Markup()" wrapper, or use the Genshi xml constuction APIs.

[cmlenz]

You can just put the Markup class in the context data. Are you using Genshi by itself, or through the template engine plugin? I guess the plugin could add the Markup class automatically (as it already does for a couple other things), but for Genshi itself I've been following the policy of not adding anything automatically (except for the Python builtins and the magic Undefined type). But maybe Markup should be an exception, I'm not sure.

[jochen.kupperschmidt@…]

Since Markup() is very common and even usually mandatory for real-world templates, I second the idea of adding it to the context by default - so users won't need to do it themselves in their application code anymore.

[cboos]

Replying to cmlenz:

... But maybe Markup should be an exception, I'm not sure.

Another exception worth considering would be Undefined (perhaps even more needed than Markup).

See e.g. ​[Trac 4348].

[cmlenz]

Replying to cboos:

Replying to cmlenz:

... But maybe Markup should be an exception, I'm not sure.

Another exception worth considering would be Undefined (perhaps even more needed than Markup).

Undefined is already an exception (as noted in the comment you replied to ;-) ). I think what you've seen was that this was broken for a bit on trunk, but it should work again now since [464].

[cboos]

Replying to cmlenz:

Undefined is already an exception (as noted in the comment you replied to ;-) ).

Oops, yes, overlooked that!

I think what you've seen was that this was broken for a bit on trunk, but it should work again now since [464].

Most probably, yes. Fixed that in ​[T4405]. Sorry for the noise ;)

[jochen.kupperschmidt@…]

So, what about finally adding Markup to make life a little easier and closing this ticket?

[cmlenz]

Done in [493].