Edgewall Software

Ticket #80 (closed defect: fixed)

Opened 23 months ago

Last modified 23 months ago

<xi:fallback> content always shown

Reported by: cboos Owned by: cmlenz
Priority: major Milestone: 0.4
Component: Template processing Version: devel
Keywords: xi:include xi:fallback Cc:

Description

With latest trunk (r462), I've noticed that the <xi:fallback> content is always shown, regardless of whether the <xi:include> target was found or not.

This is visible e.g. in Trac's report template.

Attachments

unit_test_xi_fallback-r462.diff (1.8 kB) - added by cboos 23 months ago.
Unit-test demonstrating the issue
fix_xi_fallback-r462.diff (1.4 kB) - added by cboos 23 months ago.
Potential fix for the issue
fix_xi_fallback-r462.2.diff (1.3 kB) - added by cboos 23 months ago.
Simplified a bit the previous fix

Change History

Changed 23 months ago by cboos

Unit-test demonstrating the issue

Changed 23 months ago by cboos

Potential fix for the issue

Changed 23 months ago by cboos

  • keywords changed from xi:include xi:fallback to xi:include xi:fallback

With attachment:fix_xi_fallback-r462.diff, the problem is solved, i.e. the first unit test added in attachment:unit_test_xi_fallback-r462.diff now succeeds and my original issue with Trac's Report template is also fixed. All the other unit-tests still pass.

Changed 23 months ago by cboos

Simplified a bit the previous fix

Changed 23 months ago by cboos

  • version changed from 0.3.3 to devel

Changed 23 months ago by cmlenz

  • status changed from new to assigned

Thanks for the patches!

Changed 23 months ago by cmlenz

  • status changed from assigned to closed
  • resolution set to fixed

Should be fixed in [463]. I expanded your patch a bit so that we can now support nested fallback content.

Add/Change #80 (<xi:fallback> content always shown)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.