Edgewall Software

Ticket #537 (closed defect: fixed)

Opened 2 years ago

Last modified 22 months ago

genshi on python 3.3 broken

Reported by: rp Owned by: hodgestar
Priority: critical Milestone: 0.7
Component: Parsing Version: 0.6
Keywords: Cc:

Description

Hi!

Genshi doesn't work with python 3.3 anymore. There is a change in the Python 3.3 ast tree syntax, they remove TryExcept? and TryFinally?, but added a combined Try node.

I attached a little patch adding a visit_Try method and hope it's kinda correct, atleast it somewhat works here.

Because I'm curious why is genshi not using the NodeVisitor? class?

Attachments

py3.3_astfix.diff Download (1.5 KB) - added by rp 2 years ago.

Change History

Changed 2 years ago by rp

Changed 2 years ago by hodgestar

  • owner changed from cmlenz to hodgestar
  • status changed from new to assigned

Changed 2 years ago by hodgestar

  • status changed from assigned to closed
  • resolution set to fixed

Thanks for the patch. I committed it in r1192. I also fixed a change in the structure of the With node (it now has .items instead of a single item directly on the node itself).

I suspect the initially implementation in Genshi predates NodeVisitor and NodeTransformer.

Add/Change #537 (genshi on python 3.3 broken)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.