Edgewall Software

Opened 18 years ago

Closed 18 years ago

Last modified 12 years ago

#42 closed defect (fixed)

Fix eval of *args and **kwargs in eval.py

Reported by: davidf@… Owned by: cmlenz
Priority: major Milestone: 0.3
Component: Expression evaluation Version: 0.2
Keywords: Cc:

Description

Using py:content="foo(*bar)" or py:content="foo(**bar)" generated an error by passing the string "bar" to the visit function rather than Name(bar): 

AttributeError: 'ExpressionASTTransformer' object has no attribute 'visitstr'

This is because node.star_args and node.dstar_args are not lists. Patch with tests and fix attached.

Attachments (1)

eval-fix-star-and-dstar-expr.patch​ (1.7 KB) - added by davidf@… 18 years ago.
patch to fix eval of *args and kwargs, with tests

Download all attachments as: .zip

Change History (3)

Changed 18 years ago by davidf@…

patch to fix eval of *args and kwargs, with tests

comment:1 Changed 18 years ago by cmlenz

  • Status changed from new to assigned
  • Version changed from devel to 0.2

Good catch, thanks for the patch!

comment:2 Changed 18 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from assigned to closed

Applied in [253].

Note: See TracTickets for help on using tickets.