Edgewall Software

Opened 7 years ago

Last modified 4 years ago

#240 reopened defect

Genshi gets relative path wrong for <xi:includes

Reported by: j@… Owned by: cmlenz
Priority: major Milestone: 0.5.1
Component: Template processing Version: 0.5
Keywords: template loader Cc: oliver@…, ryan@…


in genshi/template/loader.py the relative_to is only used if its not an absolute path, this has to be os.path.isabs(filename) instead. this fixes problems related to xi:includes of templates with the same name in two direcotries, since right now just the filename is used as cachekey not the absolute path of the template.

Attachments (1)

genshi0.5_proper_relative_to.patch (557 bytes) - added by j 7 years ago.
patch to check filename

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by j

patch to check filename

comment:1 Changed 7 years ago by cmlenz

  • Component changed from General to Template processing
  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in [895], but I forgot to close this ticket. See also dupe #245.

comment:2 Changed 7 years ago by Oliver <oliver@…>

  • Keywords template loader added
  • Resolution fixed deleted
  • Status changed from closed to reopened

I would like to reopen this bug again...same bug and same solution.

comment:3 Changed 7 years ago by Oliver <oliver@…>

  • Cc oliver@… added

comment:4 Changed 6 years ago by pj@…

This is a major issue with no activity in 2 months? :(

comment:5 Changed 6 years ago by rpetrello

  • Cc ryan@… added

Any news or progress on this issue? We're still experiencing it in Genshi 0.5.1 w/ the latest TurboGears (TG2.1a3 and TG2.1b1).

comment:6 Changed 4 years ago by Libby

Is that really all there is to it because that'd be fblabegrasting.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
as reopened The owner will remain cmlenz.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from cmlenz to the specified user. Next status will be 'new'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.