Edgewall Software

Ticket #240 (reopened defect)

Opened 6 years ago

Last modified 3 years ago

Genshi gets relative path wrong for <xi:includes

Reported by: j@… Owned by: cmlenz
Priority: major Milestone: 0.5.1
Component: Template processing Version: 0.5
Keywords: template loader Cc: oliver@…, ryan@…

Description

in genshi/template/loader.py the relative_to is only used if its not an absolute path, this has to be os.path.isabs(filename) instead. this fixes problems related to xi:includes of templates with the same name in two direcotries, since right now just the filename is used as cachekey not the absolute path of the template.

Attachments

genshi0.5_proper_relative_to.patch Download (0.5 KB) - added by j 6 years ago.
patch to check filename

Change History

Changed 6 years ago by j

patch to check filename

Changed 6 years ago by cmlenz

  • status changed from new to closed
  • resolution set to fixed
  • component changed from General to Template processing

This was fixed in [895], but I forgot to close this ticket. See also dupe #245.

Changed 6 years ago by Oliver <oliver@…>

  • status changed from closed to reopened
  • keywords template loader added
  • resolution fixed deleted

I would like to reopen this bug again...same bug and same solution.

Changed 5 years ago by Oliver <oliver@…>

  • cc oliver@… added

Changed 5 years ago by pj@…

This is a major issue with no activity in 2 months? :(

Changed 5 years ago by rpetrello

  • cc ryan@… added

Any news or progress on this issue? We're still experiencing it in Genshi 0.5.1 w/ the latest TurboGears (TG2.1a3 and TG2.1b1).

Changed 3 years ago by Libby

Is that really all there is to it because that'd be fblabegrasting.

Add/Change #240 (Genshi gets relative path wrong for <xi:includes)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as reopened
as The resolution will be set. Next status will be 'closed'
to The owner will change from cmlenz. Next status will be 'new'
 
Note: See TracTickets for help on using tickets.